Skip to content

Conversation

@razvan
Copy link
Member

@razvan razvan commented Jun 16, 2025

Description

Part of: stackabletech/issues#735

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@razvan razvan changed the title fix: re-enable the jmx exporter for history fix: re-enable the jmx exporter Jun 16, 2025
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Jun 16, 2025
@razvan razvan requested a review from a team June 16, 2025 13:10
@dervoeti dervoeti self-requested a review June 16, 2025 13:14
@dervoeti dervoeti moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 16, 2025
@razvan razvan added this pull request to the merge queue Jun 17, 2025
Merged via the queue into main with commit 486f4ab Jun 17, 2025
17 checks passed
@razvan razvan deleted the fix/add-prometheus-exporter branch June 17, 2025 08:31
@dervoeti dervoeti moved this from Development: In Review to Development: Done in Stackable Engineering Jun 20, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants